Closed
Bug 860184
Opened 11 years ago
Closed 11 years ago
Automatically use the x86-64 NDK toolchain when possible
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla23
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(1 file)
5.85 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #735641 -
Flags: review?(ted)
Assignee | ||
Comment 2•11 years ago
|
||
Adrian, can you test this patch works for you (that is, whether it allows you to build without adding --with-android-toolchain to your mozconfig)
Flags: needinfo?(adrian.tamas)
Comment 3•11 years ago
|
||
I no longer get a request to setup the toolchain variable with this patch. Will also add an update when the build is completed
Flags: needinfo?(adrian.tamas)
Comment 4•11 years ago
|
||
Build was successful using NDK r8e and no option for the toolchain in mozconfig
Comment 5•11 years ago
|
||
Comment on attachment 735641 [details] [diff] [review] Automatically use the x86-64 NDK toolchain when possible Review of attachment 735641 [details] [diff] [review]: ----------------------------------------------------------------- ::: build/autoconf/android.m4 @@ +85,5 @@ > + ;; > + x86_64) > + android_toolchain="$android_ndk"/toolchains/$target_name/prebuilt/$kernel_name-x86_64 > + if ! test -d "$android_toolchain" ; then > + android_toolchain="$android_ndk"/toolchains/$target_name/prebuilt/$kernel_name-x86 Kind of sucks to repeat this path twice, but it's not the end of the world.
Attachment #735641 -
Flags: review?(ted) → review+
Assignee | ||
Comment 6•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/8b8b3f270ee6
Comment 7•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/8b8b3f270ee6
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•